[
https://issues.apache.org/jira/browse/HBASE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652645#comment-13652645
]
Himanshu Vashishtha commented on HBASE-8497:
--------------------------------------------
Thanks for the review.
bq. In fact probably error out at the end of the read if we read into trailer?
Agree.
bq. This usage pattern is not very clean, either external user can set the
trailer or writer can create it.
What use case you are thinking about for adding trailer and let Writer
augmenting fields to it. The use case I was thinking is adding RegionLoad level
data (completeSequenceNumbers of regions, etc) which is present at the
RegionServer (6774). You don't know such details while opening a new log,
therefore I didn't add it in ctr, and rather, exposed these setters/getters for
it. Does this help?
bq. Using Bytes stuff in both places.
Agree, lets be safe :)
bq. Is another test for corrupt trailer needed?
Not sure. You mean some incomplete trailer or something like that?
will fix those Spacing Nits.
> Protobuf WAL also needs a trailer
> ----------------------------------
>
> Key: HBASE-8497
> URL: https://issues.apache.org/jira/browse/HBASE-8497
> Project: HBase
> Issue Type: Sub-task
> Components: Protobufs, wal
> Affects Versions: 0.95.1
> Reporter: Enis Soztutar
> Assignee: Himanshu Vashishtha
> Fix For: 0.98.0, 0.95.1
>
> Attachments: HBASE-8497-v0.patch
>
>
> New Protobuf WAL has a header, but we will probably need a trailer as well,
> reserved for later usage.
> Right now, we can we just serialize an empty trailer, but putting more
> metadata there, like range of sequence_id's, region names, table names etc
> might be needed in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
