[
https://issues.apache.org/jira/browse/HBASE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653261#comment-13653261
]
Sergey Shelukhin commented on HBASE-8497:
-----------------------------------------
bq. What use case you are thinking about for adding trailer and let Writer
augmenting fields to it. The use case I was thinking is adding RegionLoad level
data (completeSequenceNumbers of regions, etc) which is present at the
RegionServer (6774). You don't know such details while opening a new log,
therefore I didn't add it in ctr, and rather, exposed these setters/getters for
it. Does this help?
In that case the log close should expect trailer to be there and not create it
imho...
{quote}
bq. Is another test for corrupt trailer needed?
Not sure. You mean some incomplete trailer or something like that?
{quote}
What I meant was writing corrupt/partial magic after correct size, for example.
> Protobuf WAL also needs a trailer
> ----------------------------------
>
> Key: HBASE-8497
> URL: https://issues.apache.org/jira/browse/HBASE-8497
> Project: HBase
> Issue Type: Sub-task
> Components: Protobufs, wal
> Affects Versions: 0.95.1
> Reporter: Enis Soztutar
> Assignee: Himanshu Vashishtha
> Fix For: 0.98.0, 0.95.1
>
> Attachments: HBASE-8497-v0.patch
>
>
> New Protobuf WAL has a header, but we will probably need a trailer as well,
> reserved for later usage.
> Right now, we can we just serialize an empty trailer, but putting more
> metadata there, like range of sequence_id's, region names, table names etc
> might be needed in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
