[ https://issues.apache.org/jira/browse/HBASE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658324#comment-13658324 ]
Eric Yu commented on HBASE-8535: -------------------------------- @stack Yes, this change is meant to correct a flaw in the testDeleteForZKConnLeak where it will occassionally fail for versions 0.95 and 0.98. On internalClose, HConnection implementation marks itself as closed and then closes watcher. So the test fails if it checks after the connection is marked as closed but before the watcher is closed. The test doesn't have access to the object used internally by HConnection to synchronize so I added a delay that double checks whether the watcher is closed if watcher was still open. I didn't always delay every time because I didn't want to slow down the test too much. > Test for zk leak does not account for unsynchronized access to zk watcher > ------------------------------------------------------------------------- > > Key: HBASE-8535 > URL: https://issues.apache.org/jira/browse/HBASE-8535 > Project: HBase > Issue Type: Test > Components: Client > Affects Versions: 0.98.0, 0.95.1 > Reporter: Eric Yu > Fix For: 0.98.0, 0.95.1 > > Attachments: HBASE-8535.patch > > > Test can detect a live zk connection in a closed hconnection because it does > not accesses the zk watcher in a synchronized manner. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira