[ 
https://issues.apache.org/jira/browse/HBASE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658693#comment-13658693
 ] 

stack commented on HBASE-8535:
------------------------------

[~ericyu] hmm... so it is just slow -- especially if connection gets trounced 
at a particularly bad time.  Maybe we don't have to cycle 50 times.  And we 
could remove the dumb log line:

{code}
diff --git 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
index 763b79f..6455c07 100644
--- 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
+++ 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
@@ -604,9 +604,8 @@ public class HConnectionManager {
       this.clusterId = this.registry.getClusterId();
       if (clusterId == null) {
         clusterId = HConstants.CLUSTER_ID_DEFAULT;
+        LOG.debug("clusterid came back null, using default " + clusterId);
       }
-
-      LOG.info("ClusterId is " + clusterId);
     }
{code} 

... to get rid of the spew.


                
> Test for zk leak does not account for unsynchronized access to zk watcher
> -------------------------------------------------------------------------
>
>                 Key: HBASE-8535
>                 URL: https://issues.apache.org/jira/browse/HBASE-8535
>             Project: HBase
>          Issue Type: Test
>          Components: Client
>    Affects Versions: 0.98.0, 0.95.1
>            Reporter: Eric Yu
>            Assignee: stack
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: HBASE-8535.patch
>
>
> Test can detect a live zk connection in a closed hconnection because it does 
> not accesses the zk watcher in a synchronized manner. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to