[ 
https://issues.apache.org/jira/browse/HBASE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658612#comment-13658612
 ] 

stack commented on HBASE-8535:
------------------------------

Hmm... the hang seems to originate in the test this patch fixes.  Search for 
'before: client.TestHCM#testDeleteForZKConnLeak' in the output above.

The test falls into a loop about here:

{code}
2013-05-15 16:07:44,351 WARN  [pool-1-thread-1] 
zookeeper.RecoverableZooKeeper(237): Possibly transient ZooKeeper, 
quorum=localhost:54737, 
exception=org.apache.zookeeper.KeeperException$ConnectionLossException: 
KeeperErrorCode = ConnectionLoss for /hbase/meta-region-server
2013-05-15 16:07:44,351 INFO  [pool-1-thread-1] util.RetryCounter(54): Sleeping 
2000ms before retry #1...
2013-05-15 16:07:44,351 DEBUG [pool-1-thread-1-EventThread] 
zookeeper.ZooKeeperWatcher(377): hconnection-0x10ea988-0x13ea8f23825000e 
connected
2013-05-15 16:07:44,352 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,354 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,355 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,356 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,359 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,360 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,362 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,364 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,365 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,366 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,366 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,367 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,368 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,369 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
2013-05-15 16:07:44,370 INFO  [test-hcm-delete-pool-267-thread-1] 
client.HConnectionManager$HConnectionImplementation(609): ClusterId is 
default-cluster
....
{code}

If you want to punt to me that is fine Eric, just say, and I'll open a new 
issue to dig in on it (minimally we should never spew as we do above the same 
INFO log every miliisecond.

                
> Test for zk leak does not account for unsynchronized access to zk watcher
> -------------------------------------------------------------------------
>
>                 Key: HBASE-8535
>                 URL: https://issues.apache.org/jira/browse/HBASE-8535
>             Project: HBase
>          Issue Type: Test
>          Components: Client
>    Affects Versions: 0.98.0, 0.95.1
>            Reporter: Eric Yu
>            Assignee: stack
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: HBASE-8535.patch
>
>
> Test can detect a live zk connection in a closed hconnection because it does 
> not accesses the zk watcher in a synchronized manner. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to