[ 
https://issues.apache.org/jira/browse/HBASE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677650#comment-13677650
 ] 

Nick Dimiduk commented on HBASE-8344:
-------------------------------------

The added comments help a naive reader, thank you!

Re: rack selection, why is the same serverID chosen on each rack? Why not 
choose a random server on each rack with each pass? (I presume there's some 
HDFS-related details with which I'm unfamiliar.)

I ran the modified tests a couple times on both hadoop-1 and hadoop-2 profiles. 
FYI, TestRegionPlacement consistently runs < 30sec for me on hadoop-1 (promote 
to SmallTest?), but *times out frequently on hadoop-2*.

My only other complaints are some whitespace nits.
                
> Improve the assignment when node failures happen to choose the secondary RS 
> as the new primary RS
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8344
>                 URL: https://issues.apache.org/jira/browse/HBASE-8344
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>            Priority: Critical
>             Fix For: 0.95.2
>
>         Attachments: hbase-8344-1.txt, hbase-8344-2.1.txt, 
> hbase-8344-2.2.txt, hbase-8344-2.3.txt, hbase-8344-2.4.txt, 
> hbase-8344-2.5.txt, hbase-8344-2.6.txt, hbase-8344-2.6.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to