[ 
https://issues.apache.org/jira/browse/HBASE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675257#comment-13675257
 ] 

Enis Soztutar commented on HBASE-8344:
--------------------------------------

Please don't use this construct (not that readable):
{code}
if ((serverWithLegitStartCode = availableServersContains(servers, s)) != null) {
{code}

segregateRegions() does not only seperate the regions with favorite nodes, but 
also assigns them. Should we rename it? 

it seems the roundrobin assignment is not randomized, so if if 100 nodes, I 
create 3 tables all with 30 regions, they all go to the same 30 racks and RSs. 
We might reuse bits of DefaultLB#roundRobinAssignment(). Other strategies might 
be to look into loads / or keep the state from last round robin assignment, but 
simple randon should be fine as a first cut. 

                
> Improve the assignment when node failures happen to choose the secondary RS 
> as the new primary RS
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8344
>                 URL: https://issues.apache.org/jira/browse/HBASE-8344
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>            Priority: Critical
>             Fix For: 0.95.2
>
>         Attachments: hbase-8344-1.txt, hbase-8344-2.1.txt, 
> hbase-8344-2.2.txt, hbase-8344-2.3.txt, hbase-8344-2.4.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to