[ 
https://issues.apache.org/jira/browse/HBASE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671824#comment-13671824
 ] 

Ted Yu commented on HBASE-8344:
-------------------------------

{code}
+  public static Position getFavoredServerPosition(
+      List<ServerName> favoredNodes, ServerName server) {
+    if (favoredNodes == null || server == null ||
+        favoredNodes.size() != FavoredNodeAssignmentHelper.FAVORED_NODES_NUM) {
{code}
Should the condition in the last line be:
{code}
favoredNodes.size() >= FavoredNodeAssignmentHelper.FAVORED_NODES_NUM
{code}
This way we can utilize some of the favored nodes.
                
> Improve the assignment when node failures happen to choose the secondary RS 
> as the new primary RS
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8344
>                 URL: https://issues.apache.org/jira/browse/HBASE-8344
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>            Priority: Critical
>             Fix For: 0.95.2
>
>         Attachments: hbase-8344-1.txt, hbase-8344-2.1.txt, 
> hbase-8344-2.2.txt, hbase-8344-2.3.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to