[
https://issues.apache.org/jira/browse/HBASE-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687300#comment-13687300
]
Matteo Bertozzi commented on HBASE-8760:
----------------------------------------
You can check RestoreSnapshotHelper.restoreReferenceFile() and
StoreFileInfo.open() to see how the link-reference file works.
anyway, keeping the file is not the solution to the problem.
You've a snapshot on disk that is not consistent since the parent reference is
missing.
aside from the fact that you can still reference the parent because the restore
of a reference is smarter, having a snapshot with a missing information is
wrong.
so the fix should be inside the snapshot... and not on the cleaner side keeping
the file just because the reference can be smart.
> possible loss of data in snapshot taken after region split
> ----------------------------------------------------------
>
> Key: HBASE-8760
> URL: https://issues.apache.org/jira/browse/HBASE-8760
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 0.94.8
> Reporter: Jerry He
> Assignee: Jerry He
> Fix For: 0.94.8
>
> Attachments: HBase-8760-0.94.8.patch, HBase-8760-0.94.8-v1.patch
>
>
> Right after a region split but before the daughter regions are compacted, we
> have two daughter regions containing Reference files to the parent hfiles.
> If we take snapshot right at the moment, the snapshot will succeed, but it
> will only contain the daughter Reference files. Since there is no hold on the
> parent hfiles, they will be deleted by the HFile Cleaner after they are no
> longer needed by the daughter regions soon after.
> A minimum we need to do is the keep these parent hfiles from being deleted.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
