[ 
https://issues.apache.org/jira/browse/HBASE-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687315#comment-13687315
 ] 

Jerry He commented on HBASE-8760:
---------------------------------

I agree.  A couple of options for thoughts.

Option 1:

1) Keep the parent hfle from the hfile cleaner. (the current patch).  
   The hfile will be there with the snapshot. But will be gone after 
delete-snapshot.
2) In RestoreSnapshotHelper.restoreReferenceFile(), change the code to either 
hold onto the parent hfile, or copy the half files?
3) Take care of ExportSnapshot too.

Option 2:

1) Include the parent hfiles in the snapshot. Disregard the daughters?

Other approaches?

                
> possible loss of data in snapshot taken after region split
> ----------------------------------------------------------
>
>                 Key: HBASE-8760
>                 URL: https://issues.apache.org/jira/browse/HBASE-8760
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 0.94.8
>            Reporter: Jerry He
>            Assignee: Jerry He
>             Fix For: 0.94.8
>
>         Attachments: HBase-8760-0.94.8.patch, HBase-8760-0.94.8-v1.patch
>
>
> Right after a region split but before the daughter regions are compacted, we 
> have two daughter regions containing Reference files to the parent hfiles.
> If we take snapshot right at the moment, the snapshot will succeed, but it 
> will only contain the daughter Reference files. Since there is no hold on the 
> parent hfiles, they will be deleted by the HFile Cleaner after they are no 
> longer needed by the daughter regions soon after.
> A minimum we need to do is the keep these parent hfiles from being deleted. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to