[
https://issues.apache.org/jira/browse/HBASE-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689107#comment-13689107
]
Jieshan Bean commented on HBASE-8774:
-------------------------------------
See HBASE-6073. It's also regarding on adding filter to Thrift2.
1 minor problem in the patch:
{code}
+ boolean this_present_filterString = true && this.isSetFilterString();
+ boolean that_present_filterString = true && that.isSetFilterString();
{code}
"true" is redundant.
In addition, I suggest to add 1 unit test. Anyway, it's a nice patch.
> Add BatchSize and Filter to Thrift2
> -----------------------------------
>
> Key: HBASE-8774
> URL: https://issues.apache.org/jira/browse/HBASE-8774
> Project: HBase
> Issue Type: New Feature
> Components: Thrift
> Affects Versions: 0.95.1
> Reporter: Hamed Madani
> Attachments: HBASE_8774.patch
>
>
> Attached Patch will add BatchSize and Filter support to Thrift2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
