[ 
https://issues.apache.org/jira/browse/HBASE-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694229#comment-13694229
 ] 

Hamed Madani commented on HBASE-8774:
-------------------------------------

Yes Lars. The reason I followed HBASE-4176 was , it made it easier for us to 
move from thrift1 to thrift2. Also it has been tested before with folks running 
thrift1. Moreover, from what I understand from HBASE-6073 it seems 

{code}
 * Specify boolean operator for TFilterList:
 *  - MUST_PASS_ALL means AND boolean operation
 *  - MUST_PASS_ONE means OR boolean operation
 */
enum TFilterListOperator {
  MUST_PASS_ALL = 0,
  MUST_PASS_ONE = 1
}

/**
* Represents a server side filter list
*
*/
struct TFilterList {
+  1: required TFilterListOperator operator,
  2: required list<TFilter> filters
}
{code}

limits you to either *AND* all filters or *OR* all of them. Whereas with 
HBASE-4176 you can have something like “(Filter1 AND Filter2) OR Filter3"
There is also HBASE-6073 close the scanner when the scanner doesn't have any 
more results to return. I can certainly merge the two to include this feature. 
Let me know what you think.
                
> Add BatchSize and Filter to Thrift2
> -----------------------------------
>
>                 Key: HBASE-8774
>                 URL: https://issues.apache.org/jira/browse/HBASE-8774
>             Project: HBase
>          Issue Type: New Feature
>          Components: Thrift
>    Affects Versions: 0.95.1
>            Reporter: Hamed Madani
>            Assignee: Hamed Madani
>         Attachments: HBASE_8774.patch
>
>
> Attached Patch will add BatchSize and Filter support to Thrift2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to