[jira] [Commented] (HIVE-10190) CBO: AST mode checks for TABLESAMPLE with AST.toString().contains("TOK_TABLESPLITSAMPLE")

[Reuben Kuhnert (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492384#comment-14492384
 ] 

Reuben Kuhnert commented on HIVE-10190:
---------------------------------------

Also, it looks like my code is failing for some reason, but I'm looking through 
the logs/links above, but not seeing why it's failing. All I see is that 
certain tests are not generating XML files, in addition to this:

{code}
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testNewConnectionConfiguration

Failing for the past 26 builds (Since Failed#3363 )
Took 0.53 sec.
Error Message

Failed to open new session: org.apache.hive.service.cli.HiveSQLException: 
java.lang.IllegalArgumentException: hive configuration 
hive.server2.thrift.http.max.worker.threads does not exists.
Stacktrace

org.apache.hive.service.cli.HiveSQLException: Failed to open new session: 
org.apache.hive.service.cli.HiveSQLException: 
java.lang.IllegalArgumentException: hive configuration 
hive.server2.thrift.http.max.worker.threads does not exists.
        at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:243)
        ...
Caused by: org.apache.hive.service.cli.HiveSQLException: Failed to open new 
session: org.apache.hive.service.cli.HiveSQLException: 
java.lang.IllegalArgumentException: hive configuration 
hive.server2.thrift.http.max.worker.threads does not exists.
        at 
org.apache.hive.service.cli.session.SessionManager.openSession(SessionManager.java:260)
        at 
org.apache.hive.service.cli.CLIService.openSessionWithImpersonation(CLIService.java:202)
        ...
Caused by: org.apache.hive.service.cli.HiveSQLException: 
java.lang.IllegalArgumentException: hive configuration 
hive.server2.thrift.http.max.worker.threads does not exists.
        at 
org.apache.hive.service.cli.session.HiveSessionImpl.configureSession(HiveSessionImpl.java:214)
        ...
Caused by: java.lang.IllegalArgumentException: hive configuration 
hive.server2.thrift.http.max.worker.threads does not exists.
        at 
org.apache.hadoop.hive.ql.processors.SetProcessor.setConf(SetProcessor.java:164)
        at 
org.apache.hadoop.hive.ql.processors.SetProcessor.setVariable(SetProcessor.java:127)
        ...
{code}

but I'm not sure how my changes would cause this. Please Advise.

> CBO: AST mode checks for TABLESAMPLE with 
> AST.toString().contains("TOK_TABLESPLITSAMPLE")
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-10190
>                 URL: https://issues.apache.org/jira/browse/HIVE-10190
>             Project: Hive
>          Issue Type: Bug
>          Components: CBO
>    Affects Versions: 1.2.0
>            Reporter: Gopal V
>            Assignee: Pengcheng Xiong
>            Priority: Trivial
>              Labels: perfomance
>         Attachments: HIVE-10190-querygen.py, HIVE-10190.01.patch, 
> HIVE-10190.02.patch, HIVE-10190.03.patch
>
>
> {code}
> public static boolean validateASTForUnsupportedTokens(ASTNode ast) {
>     String astTree = ast.toStringTree();
>     // if any of following tokens are present in AST, bail out
>     String[] tokens = { "TOK_CHARSETLITERAL", "TOK_TABLESPLITSAMPLE" };
>     for (String token : tokens) {
>       if (astTree.contains(token)) {
>         return false;
>       }
>     }
>     return true;
>   }
> {code}
> This is an issue for a SQL query which is bigger in AST form than in text 
> (~700kb).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)