[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488174#comment-14488174
]
Laljo John Pullokkaran commented on HIVE-10190:
-----------------------------------------------
[~sircodesalot] I looked at the relevant code and looked at your patch, let me
summarize:
The issue with the current code is:
1. It generates string from AST
2. Does search of the full string
Your patch definitely avoids generating string from AST.
I am wondering if there are CommonTree/BaseTree utility classes that may
suffice our search requirements (especially if it can use using token ids)?
> CBO: AST mode checks for TABLESAMPLE with
> AST.toString().contains("TOK_TABLESPLITSAMPLE")
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-10190
> URL: https://issues.apache.org/jira/browse/HIVE-10190
> Project: Hive
> Issue Type: Bug
> Components: CBO
> Affects Versions: 1.2.0
> Reporter: Gopal V
> Assignee: Pengcheng Xiong
> Priority: Trivial
> Labels: perfomance
> Attachments: HIVE-10190-querygen.py, HIVE-10190.01.patch,
> HIVE-10190.02.patch
>
>
> {code}
> public static boolean validateASTForUnsupportedTokens(ASTNode ast) {
> String astTree = ast.toStringTree();
> // if any of following tokens are present in AST, bail out
> String[] tokens = { "TOK_CHARSETLITERAL", "TOK_TABLESPLITSAMPLE" };
> for (String token : tokens) {
> if (astTree.contains(token)) {
> return false;
> }
> }
> return true;
> }
> {code}
> This is an issue for a SQL query which is bigger in AST form than in text
> (~700kb).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
