[ 
https://issues.apache.org/jira/browse/HIVE-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406760#comment-16406760
 ] 

Peter Vary commented on HIVE-18755:
-----------------------------------

Uhh.. :( Communication error on my side. Reading back what I have wrote, I do 
not know how I ended up with this sentence :(

I was referring this kind of changes, when we are using the default value not 
in the HiveMetaStore code:
{code:java|title=ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java}
private int createView(Hive db, CreateViewDesc crtView) throws HiveException {
[..]
new CreationMetadata(MetaStoreUtils.getDefaultCatalog(conf), tbl.getDbName()
[..]
}
{code}
Maybe doing this defaulting when using the CreationMetadata values would be 
better. Why did you decided against it?

Thanks,
Peter


> Modifications to the metastore for catalogs
> -------------------------------------------
>
>                 Key: HIVE-18755
>                 URL: https://issues.apache.org/jira/browse/HIVE-18755
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Metastore
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>            Priority: Major
>              Labels: pull-request-available
>
> Step 1 of adding catalogs is to add support in the metastore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to