[
https://issues.apache.org/jira/browse/HIVE-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410925#comment-16410925
]
Alexander Kolbasov commented on HIVE-18755:
-------------------------------------------
Looking at thrift changes first. A few comments there:
# There are many cases where the catalog is not added as the last field but
elsewhere in the existing structure and some places where it is added as
required field. I think this breaks on the wire compatibility for Thrift.
# Please document *all* additions to the thrift file. It is an API spec and not
having comments there is completely unacceptable.
The spec for catalog says:
{code}
struct Catalog {
1: string name,
2: optional string description,
3: string locationUri
}
struct CatalogName {
1: string name
}
{code}
What is CatalogName and why it is a separate struct?
What is Location for catalog and why it is not optional?
> Modifications to the metastore for catalogs
> -------------------------------------------
>
> Key: HIVE-18755
> URL: https://issues.apache.org/jira/browse/HIVE-18755
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.0.0
>
> Attachments: HIVE-18755.2.patch, HIVE-18755.nothrift, HIVE-18755.patch
>
>
> Step 1 of adding catalogs is to add support in the metastore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
