[
https://issues.apache.org/jira/browse/HIVE-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412133#comment-16412133
]
Alexander Kolbasov commented on HIVE-18755:
-------------------------------------------
Thanks for the clarification - it isn't immediately clear which structures are
old and which are new. Any reason not be consistent and make catalog always
optional?
Your reasoning for CatalogName makes sense but what do you think about having a
request structure instead?
Some more questions.
# Your current API assumes that catalogs must be created before they can be
used. Is there any value in auto-creating them on first use or this is too
complicated?
# I don't get the argument about Location - what does it mean 'place where data
in the catalog will be stored?' Different data may be stored in different
places. Even in the case of Hive every Database has its own location so what
does it mean to have a catalog location? Is it some kind of default for
Database locations when they are not specified? Why not just have Parameters
instead (which may be way more useful) and if someone wants to store Location
parameter it is just another parameter. Ot you envision HMS actually
interpreting this Location field in some form?
# create_catalog() has Catalog as the only argument. What of later you want to
change this to take more arguments? Wouldn't it be better to have
CreateCatalogRequest?
# Why get_catalogs returns list of strings rather then list of catalogs? At the
minimum the name is misleading. Also, would it make sense to add Request
structure there by the time you'll want to add a namespace that all catalogs
belong to?
# # drop_catalog - should it get request structure as an arg? What happens with
all things inside the catalog when catalog is dropped? What is the general
semantics?
> Modifications to the metastore for catalogs
> -------------------------------------------
>
> Key: HIVE-18755
> URL: https://issues.apache.org/jira/browse/HIVE-18755
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.0.0
>
> Attachments: HIVE-18755.2.patch, HIVE-18755.nothrift, HIVE-18755.patch
>
>
> Step 1 of adding catalogs is to add support in the metastore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
