[jira] [Commented] (HIVE-22570) Review of ExprNodeDesc.java

[Peter Vary (Jira)]

    [ 
https://issues.apache.org/jira/browse/HIVE-22570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991710#comment-16991710
 ] 

Peter Vary commented on HIVE-22570:
-----------------------------------

Hi David,

I am concerned about this kind of changes:
{code}
          public List<String> getCols() {
            return Collections.emptyList();
          }
{code}
Changing the return value from {{null}} to empty list in a public method can 
cause different behavior when used...

> Review of ExprNodeDesc.java
> ---------------------------
>
>                 Key: HIVE-22570
>                 URL: https://issues.apache.org/jira/browse/HIVE-22570
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HIVE-22570.1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)