[
https://issues.apache.org/jira/browse/HIVE-22570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994541#comment-16994541
]
Peter Vary commented on HIVE-22570:
-----------------------------------
[~belugabehr]: 2 things to keep in mind:
* If we do not throw a NullPointerException on the places you mentioned, that
still can cause problems in a badly written code - Happily we know Hive does
not have this issues :)
* {{Utilities.mergeUniqElems}} might be worth to enhance the null check with
emptiness check, otherwise we might have a small performance degradation
(src.isEmpty, but dest is not empty so we end up iterating through the dest
list)
Thanks,
Peter
> Review of ExprNodeDesc.java
> ---------------------------
>
> Key: HIVE-22570
> URL: https://issues.apache.org/jira/browse/HIVE-22570
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HIVE-22570.1.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
