[
https://issues.apache.org/jira/browse/HIVE-22570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991720#comment-16991720
]
David Mollitor commented on HIVE-22570:
---------------------------------------
[~pvary] Thanks for the review.
This change would be for Hive 4.0 so should be OK to make this kind of change.
Returning a null sucks.
https://github.com/google/guava/wiki/UsingAndAvoidingNullExplained
Does a 'null' value mean that there are no children? If so, what does it mean
if the method returns a list with no elements in it? How are those two things
different? It's very ambiguous and hard to reason about. Much better to say
"if I have no children, just say so... return a list with no elements".
> Review of ExprNodeDesc.java
> ---------------------------
>
> Key: HIVE-22570
> URL: https://issues.apache.org/jira/browse/HIVE-22570
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HIVE-22570.1.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
