[
https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=359589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359589
]
ASF GitHub Bot logged work on HIVE-22536:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/19 19:06
Start Date: 13/Dec/19 19:06
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #866: HIVE-22536
Improve return path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357789226
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -3025,8 +3025,7 @@ private RelNode genTableLogicalPlan(String tableAlias,
QB qb) throws SemanticExc
db, tabNameToTabObject, partitionCache, colStatsCache,
noColsMissingStats);
final TableScan scan = new HiveTableScan(cluster,
cluster.traitSetOf(HiveRelNode.CONVENTION),
optTable, null == tableAlias ? tabMetaData.getTableName() :
tableAlias,
- getAliasId(tableAlias, qb), HiveConf.getBoolVar(conf,
- HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP),
qb.isInsideView()
+ getAliasId(tableAlias, qb), ReturnPathManager.shouldUse(),
qb.isInsideView()
Review comment:
We should try with `false` hardcoded. If we set it to `true` by default, I
believe it will change aliases for all plans once we enable return path (which
also makes it more difficult to debug queries since these are synthetic aliases
vs the aliases specified in the SQL query). Note that the boolean is used in
`explainTerms` in `HiveTableScan` and the path for value `false` has changed
since this boolean was created: I do not recall all details, but it may be that
things work properly currently if we just set the value to `false`. A good way
to verify would be to run all q tests matching `cbo_.*` hardcoding it to
`false` in the `HiveTableScan` creation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 359589)
Time Spent: 2h (was: 1h 50m)
> Improve return path enabling/disabling
> --------------------------------------
>
> Key: HIVE-22536
> URL: https://issues.apache.org/jira/browse/HIVE-22536
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch,
> HIVE-22536.03.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be
> on/off/supported. In case of "supported" it should be used for a subset of
> commands which are already verified to be able to work with return path. This
> is a temporary solution for the time while we are developing return path,
> before making it the only way to handle commands.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
