[ https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=359403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359403 ]
ASF GitHub Bot logged work on HIVE-22536: ----------------------------------------- Author: ASF GitHub Bot Created on: 13/Dec/19 13:50 Start Date: 13/Dec/19 13:50 Worklog Time Spent: 10m Work Description: miklosgergely commented on pull request #866: HIVE-22536 Improve return path enabling/disabling URL: https://github.com/apache/hive/pull/866#discussion_r357652836 ########## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ########## @@ -1663,7 +1663,8 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal HIVE_CBO_CNF_NODES_LIMIT("hive.cbo.cnf.maxnodes", -1, "When converting to conjunctive normal form (CNF), fail if" + "the expression exceeds this threshold; the threshold is expressed in terms of number of nodes (leaves and" + "interior nodes). -1 to not set up a threshold."), - HIVE_CBO_RETPATH_HIVEOP("hive.cbo.returnpath.hiveop", false, "Flag to control calcite plan to hive operator conversion"), + HIVE_CBO_RETPATH_HIVEOP("hive.cbo.returnpath.hiveop", "supported", Review comment: fixed, thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 359403) Time Spent: 1h 20m (was: 1h 10m) > Improve return path enabling/disabling > -------------------------------------- > > Key: HIVE-22536 > URL: https://issues.apache.org/jira/browse/HIVE-22536 > Project: Hive > Issue Type: Sub-task > Components: Hive > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch, > HIVE-22536.03.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Instead of having a boolean for hive.cbo.returnpath.hiveop it should be > on/off/supported. In case of "supported" it should be used for a subset of > commands which are already verified to be able to work with return path. This > is a temporary solution for the time while we are developing return path, > before making it the only way to handle commands. -- This message was sent by Atlassian Jira (v8.3.4#803005)