[ 
https://issues.apache.org/jira/browse/HIVE-22990?focusedWorklogId=404443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404443
 ]

ASF GitHub Bot logged work on HIVE-22990:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Mar/20 04:22
            Start Date: 17/Mar/20 04:22
    Worklog Time Spent: 10m 
      Work Description: maheshk114 commented on pull request #949: HIVE-22990 
Add file based ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r393437622
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
 ##########
 @@ -146,7 +146,7 @@ public int execute() {
         }
         prepareReturnValues(Arrays.asList(currentDumpPath.toUri().toString(), 
String.valueOf(lastReplId)));
         writeDumpCompleteAck(hiveDumpRoot);
-        deletePreviousDumpMeta(previousDumpMetaPath);
+        deleteAllPreviousDumpMeta(dumpRoot, currentDumpPath);
 
 Review comment:
   But load ..reads all the path and loads only the latest one ..so there is a 
race condition ..
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 404443)
    Time Spent: 3h 50m  (was: 3h 40m)

> Build acknowledgement mechanism for repl dump and load
> ------------------------------------------------------
>
>                 Key: HIVE-22990
>                 URL: https://issues.apache.org/jira/browse/HIVE-22990
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Aasha Medhi
>            Assignee: Aasha Medhi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22990.01.patch, HIVE-22990.02.patch, 
> HIVE-22990.03.patch, HIVE-22990.04.patch, HIVE-22990.05.patch, 
> HIVE-22990.06.patch, HIVE-22990.07.patch, HIVE-22990.08.patch, 
> HIVE-22990.09.patch, HIVE-22990.10.patch, HIVE-22990.11.patch, 
> HIVE-22990.12.patch, HIVE-22990.13.patch, HIVE-22990.14.patch, 
> HIVE-22990.15.patch, HIVE-22990.16.patch, HIVE-22990.17.patch, 
> HIVE-22990.18.patch, HIVE-22990.19.patch, HIVE-22990.patch
>
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to