[
https://issues.apache.org/jira/browse/HIVE-22990?focusedWorklogId=404942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404942
]
ASF GitHub Bot logged work on HIVE-22990:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/20 20:22
Start Date: 17/Mar/20 20:22
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on pull request #949: HIVE-22990
Add file based ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r393945947
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -398,6 +319,21 @@ private void dropTablesExcludedInReplScope(ReplScope
replScope) throws HiveExcep
dbName);
}
+ private void createReplLoadCompleteAckTask() {
+ if ((work.isIncrementalLoad() &&
!work.incrementalLoadTasksBuilder().hasMoreWork() &&
!work.hasBootstrapLoadTasks())
Review comment:
During incremental, when we have no events in dump and only external tables
are present, will the event folder still be created? If not the check
work.incrementalLoadTasksBuilder().hasMoreWork() might not suffice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 404942)
Time Spent: 5h 10m (was: 5h)
> Build acknowledgement mechanism for repl dump and load
> ------------------------------------------------------
>
> Key: HIVE-22990
> URL: https://issues.apache.org/jira/browse/HIVE-22990
> Project: Hive
> Issue Type: Bug
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22990.01.patch, HIVE-22990.02.patch,
> HIVE-22990.03.patch, HIVE-22990.04.patch, HIVE-22990.05.patch,
> HIVE-22990.06.patch, HIVE-22990.07.patch, HIVE-22990.08.patch,
> HIVE-22990.09.patch, HIVE-22990.10.patch, HIVE-22990.11.patch,
> HIVE-22990.12.patch, HIVE-22990.13.patch, HIVE-22990.14.patch,
> HIVE-22990.15.patch, HIVE-22990.16.patch, HIVE-22990.17.patch,
> HIVE-22990.18.patch, HIVE-22990.19.patch, HIVE-22990.20.patch,
> HIVE-22990.21.patch, HIVE-22990.22.patch, HIVE-22990.23.patch,
> HIVE-22990.patch
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
