[
https://issues.apache.org/jira/browse/HIVE-22990?focusedWorklogId=404821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404821
]
ASF GitHub Bot logged work on HIVE-22990:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/20 15:56
Start Date: 17/Mar/20 15:56
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on pull request #949: HIVE-22990
Add file based ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r393782909
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -312,7 +312,22 @@ public void testBasic() throws IOException {
verifySetup("SELECT * from " + dbName + ".unptned_empty", empty, driver);
String replicatedDbName = dbName + "_dupe";
- bootstrapLoadAndVerify(dbName, replicatedDbName);
+ Tuple bootstrapDump = bootstrapLoadAndVerify(dbName, replicatedDbName);
+
+ FileSystem fs = new Path(bootstrapDump.dumpLocation).getFileSystem(hconf);
+ Path dumpPath = new Path(bootstrapDump.dumpLocation,
ReplUtils.REPL_HIVE_BASE_DIR);
+ boolean dumpAckFound = false;
+ boolean loadAckFound = false;
+ for (FileStatus status : fs.listStatus(dumpPath)) {
+ if
(status.getPath().getName().equalsIgnoreCase(ReplUtils.DUMP_ACKNOWLEDGEMENT)) {
+ dumpAckFound = true;
+ }
+ if
(status.getPath().getName().equalsIgnoreCase(ReplUtils.LOAD_ACKNOWLEDGEMENT)) {
+ loadAckFound = true;
+ }
+ }
+ assertTrue(dumpAckFound);
+ assertTrue(loadAckFound);
Review comment:
Why not just use:
assertTrue(fs.exists(new Path(dumpPath, ReplUtils.DUMP_ACKNOWLEDGEMENT)));
assertTrue(fs.exists(new Path(dumpPath, ReplUtils.LOAD_ACKNOWLEDGEMENT)));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 404821)
Time Spent: 4.5h (was: 4h 20m)
> Build acknowledgement mechanism for repl dump and load
> ------------------------------------------------------
>
> Key: HIVE-22990
> URL: https://issues.apache.org/jira/browse/HIVE-22990
> Project: Hive
> Issue Type: Bug
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22990.01.patch, HIVE-22990.02.patch,
> HIVE-22990.03.patch, HIVE-22990.04.patch, HIVE-22990.05.patch,
> HIVE-22990.06.patch, HIVE-22990.07.patch, HIVE-22990.08.patch,
> HIVE-22990.09.patch, HIVE-22990.10.patch, HIVE-22990.11.patch,
> HIVE-22990.12.patch, HIVE-22990.13.patch, HIVE-22990.14.patch,
> HIVE-22990.15.patch, HIVE-22990.16.patch, HIVE-22990.17.patch,
> HIVE-22990.18.patch, HIVE-22990.19.patch, HIVE-22990.20.patch,
> HIVE-22990.21.patch, HIVE-22990.22.patch, HIVE-22990.patch
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
