[
https://issues.apache.org/jira/browse/HIVE-24270?focusedWorklogId=500883&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500883
]
ASF GitHub Bot logged work on HIVE-24270:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/20 22:56
Start Date: 14/Oct/20 22:56
Worklog Time Spent: 10m
Work Description: mustafaiman commented on a change in pull request #1577:
URL: https://github.com/apache/hive/pull/1577#discussion_r505043441
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
##########
@@ -1852,6 +1863,9 @@ public void close() throws IOException {
closeSparkSession();
registry.closeCUDFLoaders();
dropSessionPaths(sessionConf);
+ if (pathCleaner != null) {
+ pathCleaner.shutdown();
Review comment:
I dont see how this happens. Everything that needs to be deleted is
guaranteed to be in PathCleaner's deleteActions list by the time shutdown is
called. PathCleaner goes over everything in the list before exiting. See:
https://github.com/apache/hive/pull/1577/files#diff-80bcef5e921dc6ac67a42ad691b771943f0ffa608454dae389c76b29139c61f9R65
I didn't get your point with 1024 entries either. That is just the initial
capacity of intermediate ArrayList. That is not an upper bound.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 500883)
Time Spent: 0.5h (was: 20m)
> Move scratchdir cleanup to background
> -------------------------------------
>
> Key: HIVE-24270
> URL: https://issues.apache.org/jira/browse/HIVE-24270
> Project: Hive
> Issue Type: Improvement
> Reporter: Mustafa Iman
> Assignee: Mustafa Iman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In cloud environment, scratchdir cleaning at the end of the query may take
> long time. This causes client to hang up to 1 minute even after the results
> were streamed back. During this time client just waits for cleanup to finish.
> Cleanup can take place in the background in HiveServer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
