[ 
https://issues.apache.org/jira/browse/HIVE-24270?focusedWorklogId=503203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-503203
 ]

ASF GitHub Bot logged work on HIVE-24270:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Oct/20 14:00
            Start Date: 21/Oct/20 14:00
    Worklog Time Spent: 10m 
      Work Description: mustafaiman commented on a change in pull request #1577:
URL: https://github.com/apache/hive/pull/1577#discussion_r509312017



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverUtils.java
##########
@@ -95,7 +95,7 @@ public static SessionState setUpSessionState(HiveConf conf, 
String user, boolean
     if (sessionState == null) {
       // Note: we assume that workers run on the same threads repeatedly, so 
we can set up
       //       the session here and it will be reused without explicitly 
storing in the worker.
-      sessionState = new SessionState(conf, user);
+      sessionState = new SessionState(conf, user, true);

Review comment:
       background threads do not need async delete. Many compaction tests 
specifically have sync assumptions. I dont see any benefit in moving background 
operations to async cleanup model.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 503203)
    Time Spent: 1h 10m  (was: 1h)

> Move scratchdir cleanup to background
> -------------------------------------
>
>                 Key: HIVE-24270
>                 URL: https://issues.apache.org/jira/browse/HIVE-24270
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Mustafa Iman
>            Assignee: Mustafa Iman
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In cloud environment, scratchdir cleaning at the end of the query may take 
> long time. This causes client to hang up to 1 minute even after the results 
> were streamed back. During this time client just waits for cleanup to finish. 
> Cleanup can take place in the background in HiveServer.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to