[
https://issues.apache.org/jira/browse/HIVE-24270?focusedWorklogId=502415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-502415
]
ASF GitHub Bot logged work on HIVE-24270:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/20 21:36
Start Date: 19/Oct/20 21:36
Worklog Time Spent: 10m
Work Description: mustafaiman commented on a change in pull request #1577:
URL: https://github.com/apache/hive/pull/1577#discussion_r508077019
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverUtils.java
##########
@@ -61,6 +61,7 @@ public static void runOnDriver(HiveConf conf, String user,
throw new
IllegalArgumentException(JavaUtils.txnIdToString(compactorTxnId) +
" is not valid. Context: " + query);
}
+ sessionState.setSyncCleanup();
Review comment:
This switch is actually meant to be constant for a specific session.
I've put it as a setter as it seemed easier than putting it in constructor(many
changes to many file). Sync cleanup is used for compactor and stats updater
thread. Everything else will be async. I believe compactor and stats updater
use their own session repeatedly. Unless a regular query re-uses
compactor/statsupdater's session, there is no need to set it back to async.
I'll double check if this is the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 502415)
Time Spent: 50m (was: 40m)
> Move scratchdir cleanup to background
> -------------------------------------
>
> Key: HIVE-24270
> URL: https://issues.apache.org/jira/browse/HIVE-24270
> Project: Hive
> Issue Type: Improvement
> Reporter: Mustafa Iman
> Assignee: Mustafa Iman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In cloud environment, scratchdir cleaning at the end of the query may take
> long time. This causes client to hang up to 1 minute even after the results
> were streamed back. During this time client just waits for cleanup to finish.
> Cleanup can take place in the background in HiveServer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
