[
https://issues.apache.org/jira/browse/HIVE-25213?focusedWorklogId=611443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611443
]
ASF GitHub Bot logged work on HIVE-25213:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/21 16:34
Start Date: 15/Jun/21 16:34
Worklog Time Spent: 10m
Work Description: dantongdong commented on a change in pull request #2371:
URL: https://github.com/apache/hive/pull/2371#discussion_r651962841
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -3799,10 +3799,33 @@ public Table get_table_core(GetTableRequest
getTableRequest) throws MetaExceptio
@Override
public GetTablesResult get_table_objects_by_name_req(GetTablesRequest req)
throws TException {
String catName = req.isSetCatName() ? req.getCatName() :
getDefaultCatalog(conf);
+ if (isDatabaseRemote(req.getDbName())) {
+ return new
GetTablesResult(getRemoteTableObjectsInternal(req.getDbName(),
req.getTblNames(), req.getTablesPattern()));
+ }
return new GetTablesResult(getTableObjectsInternal(catName,
req.getDbName(),
req.getTblNames(), req.getCapabilities(), req.getProjectionSpec(),
req.getTablesPattern()));
}
+ private String tableNames2regex(List<String> tableNames) {
+ return "/^(" + String.join("|", tableNames) + ")$/";
Review comment:
Good catch. Will look into that. As a side note, it seems that at least
mysql does not like ".*" to be passed in as a regex getTable API call and will
throw an error. I have to manually changed the regex to null, is it normal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 611443)
Time Spent: 40m (was: 0.5h)
> Implement List<Table> getTables() for existing connectors.
> ----------------------------------------------------------
>
> Key: HIVE-25213
> URL: https://issues.apache.org/jira/browse/HIVE-25213
> Project: Hive
> Issue Type: Sub-task
> Reporter: Naveen Gangam
> Assignee: Dantong Dong
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In the initial implementation, connector providers do not implement the
> getTables(string pattern) spi. We had deferred it for later. Only
> getTableNames() and getTable() were implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
