[
https://issues.apache.org/jira/browse/HIVE-25213?focusedWorklogId=611475&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611475
]
ASF GitHub Bot logged work on HIVE-25213:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/21 17:19
Start Date: 15/Jun/21 17:19
Worklog Time Spent: 10m
Work Description: dantongdong commented on a change in pull request #2371:
URL: https://github.com/apache/hive/pull/2371#discussion_r651997059
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java
##########
@@ -129,7 +129,30 @@ protected Connection getConnection() {
* @throws MetaException To indicate any failures with executing this API
* @param regex
*/
- @Override public abstract List<Table> getTables(String regex) throws
MetaException;
+ @Override public List<Table> getTables(String regex) throws MetaException {
+ ResultSet rs = null;
+ try {
+ rs = fetchTablesViaDBMetaData(regex);
+ if (rs != null) {
+ List<Table> tables = new ArrayList<Table>();
+ while(rs.next()) {
+ tables.add(getTable(rs.getString(3)));
Review comment:
If I am looking at the right
[place](https://javadoc.scijava.org/Java6/java/sql/DatabaseMetaData.html). It
does not specify its behavior neither. But I think it makes more sense to just
leave out the one with column exception and continue returning the rest instead
of stopping? Because we want the behavior to be as close as getTables(), we can
just filter out the ones that has corrupted columns and return as many as we
can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 611475)
Time Spent: 50m (was: 40m)
> Implement List<Table> getTables() for existing connectors.
> ----------------------------------------------------------
>
> Key: HIVE-25213
> URL: https://issues.apache.org/jira/browse/HIVE-25213
> Project: Hive
> Issue Type: Sub-task
> Reporter: Naveen Gangam
> Assignee: Dantong Dong
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In the initial implementation, connector providers do not implement the
> getTables(string pattern) spi. We had deferred it for later. Only
> getTableNames() and getTable() were implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
