[
https://issues.apache.org/jira/browse/HIVE-25213?focusedWorklogId=614663&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614663
]
ASF GitHub Bot logged work on HIVE-25213:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/21 18:42
Start Date: 24/Jun/21 18:42
Worklog Time Spent: 10m
Work Description: dantongdong commented on a change in pull request #2371:
URL: https://github.com/apache/hive/pull/2371#discussion_r658196105
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java
##########
@@ -53,7 +53,6 @@
private static final String JDBC_OUTPUTFORMAT_CLASS =
"org.apache.hive.storage.jdbc.JdbcOutputFormat".intern();
String type = null; // MYSQL, POSTGRES, ORACLE, DERBY, MSSQL, DB2 etc.
- String driverClassName = null;
Review comment:
AbstractJDBCConnectorProvider Class extends
AbstractDataConnectorProvider(super) Class. driverClassName is already a field
in the super class. Having driverClassName=null here will overwrite the passed
in driverClassName by specific provider, as AbstractJDBCConnectorProvider
constructor is calling its super class constructor. This line is the root cause
of "Could not find a provider for remote database" error. Removing the line
will stop the overwritten problem. All the provider can set driverClassName via
calling AbstractDataConnectorProvider's constructor, which is what
AbstractJDBCConnectorProvider is doing for all the providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 614663)
Time Spent: 1h 20m (was: 1h 10m)
> Implement List<Table> getTables() for existing connectors.
> ----------------------------------------------------------
>
> Key: HIVE-25213
> URL: https://issues.apache.org/jira/browse/HIVE-25213
> Project: Hive
> Issue Type: Sub-task
> Reporter: Naveen Gangam
> Assignee: Dantong Dong
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In the initial implementation, connector providers do not implement the
> getTables(string pattern) spi. We had deferred it for later. Only
> getTableNames() and getTable() were implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
