[ 
https://issues.apache.org/jira/browse/HIVE-26239?focusedWorklogId=774099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774099
 ]

ASF GitHub Bot logged work on HIVE-26239:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/May/22 15:57
            Start Date: 24/May/22 15:57
    Worklog Time Spent: 10m 
      Work Description: ramesh0201 commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880692865


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -314,12 +314,10 @@ public void load(MapJoinTableContainer[] mapJoinTables,
       } catch (InterruptedException e) {
         Thread.currentThread().interrupt();
         throw new HiveException(e);
-      } catch (IOException e) {
-        throw new HiveException(e);
-      } catch (SerDeException e) {
-        throw new HiveException(e);
       } catch (Exception e) {
         throw new HiveException(e);
+      } finally {
+        loadExecService.shutdownNow();

Review Comment:
   Yes, Agree. Thanks for pointing this. Also added a null check.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 774099)
    Time Spent: 1h  (was: 50m)

> Shutdown Hash table load executor service threads when they are interrupted
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-26239
>                 URL: https://issues.apache.org/jira/browse/HIVE-26239
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ramesh Kumar Thangarajan
>            Assignee: Ramesh Kumar Thangarajan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to