[
https://issues.apache.org/jira/browse/HIVE-26239?focusedWorklogId=774156&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774156
]
ASF GitHub Bot logged work on HIVE-26239:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/22 17:59
Start Date: 24/May/22 17:59
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880805144
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -294,7 +295,10 @@ public void load(MapJoinTableContainer[] mapJoinTables,
LOG.info("Finished loading the queue for input: {} waiting {} minutes
for TPool shutdown", inputName, 2);
addQueueDoneSentinel();
loadExecService.shutdown();
- loadExecService.awaitTermination(2, TimeUnit.MINUTES);
+
+ if (!loadExecService.awaitTermination(2, TimeUnit.MINUTES)) {
+ throw new HiveException("Failed to complete the hash table loader.
Loading timed out.");
Review Comment:
Catch and rethrow in the surrounding try-catch?,
```
} catch(HiveException he) {
throw he;
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 774156)
Time Spent: 1h 50m (was: 1h 40m)
> Shutdown Hash table load executor service threads when they are interrupted
> ---------------------------------------------------------------------------
>
> Key: HIVE-26239
> URL: https://issues.apache.org/jira/browse/HIVE-26239
> Project: Hive
> Issue Type: Bug
> Reporter: Ramesh Kumar Thangarajan
> Assignee: Ramesh Kumar Thangarajan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
