[
https://issues.apache.org/jira/browse/HIVE-26239?focusedWorklogId=774116&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774116
]
ASF GitHub Bot logged work on HIVE-26239:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/22 16:30
Start Date: 24/May/22 16:30
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880726160
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -312,13 +312,11 @@ public void load(MapJoinTableContainer[] mapJoinTables,
inputName, cacheKey, receivedEntries, delta);
}
} catch (InterruptedException e) {
+ loadExecService.shutdownNow();
Review Comment:
There is :
```
loadExecService.awaitTermination(2, TimeUnit.MINUTES)
```
This just waits 2 minutes, doesn't throw any exception, if the tasks don't
get completed in 2 mins. Now if we waited 120 seconds and the task was supposed
to be completed in 122 seconds. We would interrupt the thread now in the
``finally`` block?
Won't the result or behaviour change post this change? say it had a chance
to complete before it gets terminated or so....
Or check for the return value of this awaitTermination and if it returns
false, we throw an Exception rather than a success, that way this finally block
might look cool
Issue Time Tracking
-------------------
Worklog Id: (was: 774116)
Time Spent: 1h 10m (was: 1h)
> Shutdown Hash table load executor service threads when they are interrupted
> ---------------------------------------------------------------------------
>
> Key: HIVE-26239
> URL: https://issues.apache.org/jira/browse/HIVE-26239
> Project: Hive
> Issue Type: Bug
> Reporter: Ramesh Kumar Thangarajan
> Assignee: Ramesh Kumar Thangarajan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
