[
https://issues.apache.org/jira/browse/HIVE-26319?focusedWorklogId=785058&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-785058
]
ASF GitHub Bot logged work on HIVE-26319:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/22 12:19
Start Date: 27/Jun/22 12:19
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3362:
URL: https://github.com/apache/hive/pull/3362#discussion_r907321359
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/WriterRegistry.java:
##########
@@ -19,26 +19,29 @@
package org.apache.iceberg.mr.hive.writer;
+import java.util.List;
import java.util.Map;
import org.apache.hadoop.mapred.TaskAttemptID;
+import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
public class WriterRegistry {
- private static final Map<TaskAttemptID, Map<String, HiveIcebergWriter>>
writers = Maps.newConcurrentMap();
+ private static final Map<TaskAttemptID, Map<String,
List<HiveIcebergWriter>>> writers = Maps.newConcurrentMap();
private WriterRegistry() {
}
- public static Map<String, HiveIcebergWriter> removeWriters(TaskAttemptID
taskAttemptID) {
+ public static Map<String, List<HiveIcebergWriter>>
removeWriters(TaskAttemptID taskAttemptID) {
return writers.remove(taskAttemptID);
}
public static void registerWriter(TaskAttemptID taskAttemptID, String
tableName, HiveIcebergWriter writer) {
writers.putIfAbsent(taskAttemptID, Maps.newConcurrentMap());
- writers.get(taskAttemptID).put(tableName, writer);
+ writers.get(taskAttemptID).putIfAbsent(tableName, Lists.newArrayList());
Review Comment:
nit: would it worth to declare a variable for this?
Issue Time Tracking
-------------------
Worklog Id: (was: 785058)
Time Spent: 3h 40m (was: 3.5h)
> Iceberg integration: Perform update split early
> -----------------------------------------------
>
> Key: HIVE-26319
> URL: https://issues.apache.org/jira/browse/HIVE-26319
> Project: Hive
> Issue Type: Improvement
> Components: File Formats
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Extend update split early to iceberg tables like in HIVE-21160 for native
> acid tables
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
