[
https://issues.apache.org/jira/browse/HIVE-26319?focusedWorklogId=785059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-785059
]
ASF GitHub Bot logged work on HIVE-26319:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/22 12:22
Start Date: 27/Jun/22 12:22
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3362:
URL: https://github.com/apache/hive/pull/3362#discussion_r907324564
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -109,8 +115,8 @@ public void commitTask(TaskAttemptContext originalContext)
throws IOException {
TaskAttemptID attemptID = context.getTaskAttemptID();
JobConf jobConf = context.getJobConf();
- Collection<String> outputs =
HiveIcebergStorageHandler.outputTables(context.getJobConf());
- Map<String, HiveIcebergWriter> writers =
Optional.ofNullable(WriterRegistry.writers(attemptID))
+ Set<String> outputs =
Sets.newHashSet(HiveIcebergStorageHandler.outputTables(context.getJobConf()));
Review Comment:
Could we change the return type for `outputTables` to `Set`?
Issue Time Tracking
-------------------
Worklog Id: (was: 785059)
Time Spent: 3h 50m (was: 3h 40m)
> Iceberg integration: Perform update split early
> -----------------------------------------------
>
> Key: HIVE-26319
> URL: https://issues.apache.org/jira/browse/HIVE-26319
> Project: Hive
> Issue Type: Improvement
> Components: File Formats
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Extend update split early to iceberg tables like in HIVE-21160 for native
> acid tables
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
