[
https://issues.apache.org/jira/browse/HIVE-26319?focusedWorklogId=785071&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-785071
]
ASF GitHub Bot logged work on HIVE-26319:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/22 12:34
Start Date: 27/Jun/22 12:34
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3362:
URL: https://github.com/apache/hive/pull/3362#discussion_r907336065
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -305,13 +414,14 @@ private Set<FileStatus> listForCommits(JobConf jobConf,
String jobLocation) thro
* Collects the additions to a single table and adds/commits the new files
to the Iceberg table.
* @param io The io to read the forCommit files
* @param executor The executor used to read the forCommit files
- * @param jobContext The job context
- * @param name The name of the table used for loading from the catalog
+ * @param outputTable The table used for loading from the catalog
* @param location The location of the table used for loading from the
catalog
* @param catalogName The name of the catalog that contains the table
*/
- private void commitTable(FileIO io, ExecutorService executor, JobContext
jobContext, String name, String location,
+ private void commitTable(FileIO io, ExecutorService executor, OutputTable
outputTable, String location,
Review Comment:
Would it make sense to put the `location` and the `catalogName` to the
`OutputTable` object?
Issue Time Tracking
-------------------
Worklog Id: (was: 785071)
Time Spent: 4h 50m (was: 4h 40m)
> Iceberg integration: Perform update split early
> -----------------------------------------------
>
> Key: HIVE-26319
> URL: https://issues.apache.org/jira/browse/HIVE-26319
> Project: Hive
> Issue Type: Improvement
> Components: File Formats
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Extend update split early to iceberg tables like in HIVE-21160 for native
> acid tables
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
