[
https://issues.apache.org/jira/browse/HIVE-27217?focusedWorklogId=854894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854894
]
ASF GitHub Bot logged work on HIVE-27217:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/23 20:52
Start Date: 04/Apr/23 20:52
Worklog Time Spent: 10m
Work Description: TuroczyX commented on PR #4197:
URL: https://github.com/apache/hive/pull/4197#issuecomment-1496591734
This is truly a best practice in any OOP language to rethrow the exception.
To swallow it is rarely a good idea, but **could be** a good choice especially
when the domain logic should manage those error scenario where exception is an
expected behaviors' from the business logic perspective.
Here as I see this notification log is mainly for
`TApplicationException.UNKNOWN_METHOD ||
TApplicationException.WRONG_METHOD_NAME) `
Which is the main use-case when a method is not implemented and it can't be
goes into notification log. Do we have here different use cases as well? If yes
then your point is right to rethrow it.
Also if you rethrow where it will be catched?
Issue Time Tracking
-------------------
Worklog Id: (was: 854894)
Time Spent: 0.5h (was: 20m)
> addWriteNotificationLogInBatch can silently fail
> ------------------------------------------------
>
> Key: HIVE-27217
> URL: https://issues.apache.org/jira/browse/HIVE-27217
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Reporter: John Sherman
> Assignee: John Sherman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Debugging an issue, I noticed that addWriteNotificationLogInBatch in
> Hive.java can fail silently if the TApplicationException thrown is not
> TApplicationException.UNKNOWN_METHOD or
> TApplicationException.WRONG_METHOD_NAME.
> https://github.com/apache/hive/blob/40a7d689e51d02fa9b324553fd1810d0ad043080/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L3359-L3381
> Failures to write in the notification log can be very difficult to debug, we
> should rethrow the exception so that the failure is very visible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
