[
https://issues.apache.org/jira/browse/HIVE-27217?focusedWorklogId=855326&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-855326
]
ASF GitHub Bot logged work on HIVE-27217:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/23 14:55
Start Date: 06/Apr/23 14:55
Worklog Time Spent: 10m
Work Description: jfsii commented on PR #4197:
URL: https://github.com/apache/hive/pull/4197#issuecomment-1499205070
> LGTM!
>
> I am +2 as it is but if had a test that goes along I would be +100 :)
>
> Would it be feasible/easy to do something similar to
`TestHiveMetaStoreClientApiArgumentsChecker` where we have a fake
`IMetaStoreClient` that throws and then put `Hive.loadDynamicPartitions` under
test? If it is too complicated I am perfectly fine merging this as is.
@zabetak I can certainly try - if it turns out that it becomes too complex
for the benefit, I'll say something.
Issue Time Tracking
-------------------
Worklog Id: (was: 855326)
Time Spent: 50m (was: 40m)
> addWriteNotificationLogInBatch can silently fail
> ------------------------------------------------
>
> Key: HIVE-27217
> URL: https://issues.apache.org/jira/browse/HIVE-27217
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Reporter: John Sherman
> Assignee: John Sherman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Debugging an issue, I noticed that addWriteNotificationLogInBatch in
> Hive.java can fail silently if the TApplicationException thrown is not
> TApplicationException.UNKNOWN_METHOD or
> TApplicationException.WRONG_METHOD_NAME.
> https://github.com/apache/hive/blob/40a7d689e51d02fa9b324553fd1810d0ad043080/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L3359-L3381
> Failures to write in the notification log can be very difficult to debug, we
> should rethrow the exception so that the failure is very visible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
