[
https://issues.apache.org/jira/browse/HIVE-27217?focusedWorklogId=856825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856825
]
ASF GitHub Bot logged work on HIVE-27217:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/23 16:06
Start Date: 13/Apr/23 16:06
Worklog Time Spent: 10m
Work Description: jfsii commented on PR #4197:
URL: https://github.com/apache/hive/pull/4197#issuecomment-1507226781
Re: @zabetak I think I'd like to give up on writing the test. I attempted
for a few hours but found it hard to mock up objects to be able to call
loadDynamicPartitions, I could take a different approach and use mockito or
something but I'm not sure it is worth it to do at this time. I also need to
work on some other items and do not want to forget about this patch. Feel free
to re-push back and I will try to make the time. Thanks!
Issue Time Tracking
-------------------
Worklog Id: (was: 856825)
Time Spent: 1h (was: 50m)
> addWriteNotificationLogInBatch can silently fail
> ------------------------------------------------
>
> Key: HIVE-27217
> URL: https://issues.apache.org/jira/browse/HIVE-27217
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Reporter: John Sherman
> Assignee: John Sherman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Debugging an issue, I noticed that addWriteNotificationLogInBatch in
> Hive.java can fail silently if the TApplicationException thrown is not
> TApplicationException.UNKNOWN_METHOD or
> TApplicationException.WRONG_METHOD_NAME.
> https://github.com/apache/hive/blob/40a7d689e51d02fa9b324553fd1810d0ad043080/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L3359-L3381
> Failures to write in the notification log can be very difficult to debug, we
> should rethrow the exception so that the failure is very visible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
