[
https://issues.apache.org/jira/browse/HIVE-14536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446635#comment-15446635
]
Peter Vary commented on HIVE-14536:
-----------------------------------
Hi,
In HIVE-14444 we discussed, that [~kgyrtkirk]'s patch goal is to remove the
ant, velocity dependency and will keep the overall structure of the tests, but
in the long run the qfile test code should be cleaned up. I proposed a
solution, which greatly reduced the number of the used classes, and helps the
future developers to find the used code with less hive specific knowledge
easier. We agreed with [~ashutoshc], and [~kgyrtkirk], that it will be the
scope of another patch, and I will do it myself.
I have submitted the patch, and pushed it to the review board, where I answered
the questions, and comments, and asked clarification if I did not understand
the original ones. I tried to make sure, that the patch does not contain any
other changes, than it is needed for the refactor, so it would be easier to
review. Please [~kgyrtkirk], [~sseth] help with further review this cleaned up
version of the patch, or if you do not have the time and the capacity to do so,
then tell me, so I could start looking for other reviewers (I would be more
comfortable with you, since I think you are the ones who has the most
understanding of this part of the code). It would be good to finish this patch,
so it will not affect other ongoing test improvement activities, and I could
move on to cleaning up other parts of the testing framework, like QTestUtil
classes, which I think all of us agrees need refactoring badly.
Thanks,
Peter
> Unit test code cleanup
> ----------------------
>
> Key: HIVE-14536
> URL: https://issues.apache.org/jira/browse/HIVE-14536
> Project: Hive
> Issue Type: Sub-task
> Components: Testing Infrastructure
> Reporter: Peter Vary
> Assignee: Peter Vary
> Attachments: HIVE-14536.5.patch, HIVE-14536.6.patch,
> HIVE-14536.7.patch, HIVE-14536.patch
>
>
> Clean up the itest infrastructure, to create a readable, easy to understand
> code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
