[
https://issues.apache.org/jira/browse/HIVE-14536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453462#comment-15453462
]
Zoltan Haindrich commented on HIVE-14536:
-----------------------------------------
Hi [~pvary],
I think I've noted that this refactor should be postponed to be after a few
other changes( in HIVE-14444, directing a comment to you... and on it's
reviewboard too) ...so I feel a bit unfair noting my name about that I've
haven't said anything about the timing of changes like this.
I've opened this HIVE-14443 ticket to enable collaboration between us...I've
made a possibly bad decision by removing all vm file related things in
HIVE-14444; but this way there is no real way back to using ant&friends now -
HIVE-14444 created a working alternative of the old ant+vm generated java file
approach using junit4...this was its mission.
Even thru i've tried to add tickets to HIVE-14443, which are usefull and can be
easily separated - and get started with collaborating...you haven't taken any
of them; instead you created this cleanup ticket - and merged a few from those
tickets into this - by opening this ticket you effectively blocked any further
work on post HIVE-14444 things...like qtestutil junit rule extraction and
separation... etc...I was not happy with your decision but I've accepted it
I'm afraid that this patch: instead of moving toward using junit4 rules and
classes with clear responsibilities; adds more properties and pushes
functionalities into the existing qtest related framework - and even "bends"
things to serve the old framework...it traded all those immutable classes to a
unified mutable one with a 9 argument constructor...I think this makes it very
similar to just using a plain qtestutil...
> Unit test code cleanup
> ----------------------
>
> Key: HIVE-14536
> URL: https://issues.apache.org/jira/browse/HIVE-14536
> Project: Hive
> Issue Type: Sub-task
> Components: Testing Infrastructure
> Reporter: Peter Vary
> Assignee: Peter Vary
> Attachments: HIVE-14536.5.patch, HIVE-14536.6.patch,
> HIVE-14536.7.patch, HIVE-14536.patch
>
>
> Clean up the itest infrastructure, to create a readable, easy to understand
> code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
