[
https://issues.apache.org/jira/browse/HIVE-14536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449727#comment-15449727
]
Siddharth Seth commented on HIVE-14536:
---------------------------------------
[~pvary] - as I said on review board, my concern is around making sure the IDE
integration work being done under HIVE-14443 reaches a logical conclusion. This
change, at this point, is not helping towards that. It's a refactor of a less
than one month old refactor. The details of what was decided with [~kgyrtkirk]
and [~ashutoshc] about additional cleanup are not known to me. I'll let them
comment on that, and decide on the timing of this patch going in.
In terms of the patch itself, first thank you for posting it, and addressing
some of the comments to get rid of the additional changes. There's still some
changes like TestBeeLineDriver which are not required as part of the refactor.
- Figuring out the hadoop version (required in the refactor, or can this be
split into a separate change?) - Hadoop has something called VersionInfo -
which may be easier to use.
- All the test code moving into QTEstUtil (runTest, runVersionedTest, etc).
Commented on RB - this should not move into QTestUtil. Move it into a separate
utility class if that helps.
- CliConfig via ctors. Think Zoltan pointed this out, and you partially agreed
- A Builder would be more explicit, and easier to understand. Also it should
not be necessary to provide properties for which reasonable defaults are
available (targetDirectory for instance).
The changes which are not part of the refactor can easily go into new jiras,
and those become easier to review independently. (beeline, UDFs, etc)
bq. and I could move on to cleaning up other parts of the testing framework,
like QTestUtil classes, which I think all of us agrees need refactoring badly.
Is there a specific goal in mind for this? There's multiple test cleanup
efforts going on - HIVE-14443 (IDE support), HIVE-13503 (framework improvements
primarily targeted at test runtimes), and HIVE-14547 (failing and flaky test
fixes, along with individual test runtime improvements). QTestUtils will see
changes as part of these fixes. Would be great if you could help out with some
of the jiras under these umbrella jiras.
I'm all for refactoring QTestUtils to clean it up. It's a horribly difficult
class to modify - with strange changes made to setup drivers, sessionstate,
parseDriver, semanticAnalyzer between each test - some of which are not always
required. Maybe push the refactor out bit a few weeks, till most of the changes
towards ide, runtimes and reliable tests are in place?
> Unit test code cleanup
> ----------------------
>
> Key: HIVE-14536
> URL: https://issues.apache.org/jira/browse/HIVE-14536
> Project: Hive
> Issue Type: Sub-task
> Components: Testing Infrastructure
> Reporter: Peter Vary
> Assignee: Peter Vary
> Attachments: HIVE-14536.5.patch, HIVE-14536.6.patch,
> HIVE-14536.7.patch, HIVE-14536.patch
>
>
> Clean up the itest infrastructure, to create a readable, easy to understand
> code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
