[
https://issues.apache.org/jira/browse/HIVE-16024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887606#comment-15887606
]
Peter Vary commented on HIVE-16024:
-----------------------------------
I think the second version of the code looks fine. I prefer not to expose the
PartitionPruner#getAllPartitions, since the perflog wrapped
Hive#getAllPartitions does the same, and it is not that much code duplication.
LGTM (non-binding)
> MSCK Repair Requires nonstrict hive.mapred.mode
> -----------------------------------------------
>
> Key: HIVE-16024
> URL: https://issues.apache.org/jira/browse/HIVE-16024
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 2.2.0
> Reporter: Barna Zsombor Klara
> Assignee: Barna Zsombor Klara
> Attachments: HIVE-16024.01.patch, HIVE-16024.02.patch
>
>
> MSCK repair fails when hive.mapred.mode is set to strict
> HIVE-13788 modified the way we read up partitions for a table to improve
> performance. Unfortunately it is using PartitionPruner to load the partitions
> which in turn is checking hive.mapred.mode.
> The previous code did not check hive.mapred.mode.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)