Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/149#discussion_r191309443 --- Diff: core/src/main/java/hivemall/fm/FactorizationMachineModel.java --- @@ -92,6 +92,14 @@ protected float getW(int i) { protected abstract void setW(@Nonnull Feature x, float nextWi); + protected void setW(int i, float nextWi) { --- End diff -- No need to have `protected void setW(int i, float nextWi)` and `protected void setW(@Nonnull String j, float nextWi)` in FactorizationMachineModel.
---