Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/149#discussion_r190842171
--- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java ---
@@ -563,6 +580,10 @@ protected void runTrainingIteration(int iterations)
throws HiveException {
inputBuf.flip();
for (int iter = 2; iter <= iterations; iter++) {
+ if (earlyStopValidation) {
--- End diff --
better to avoid many `if (earlyStopValidation) {`.
`_validateState` can always be non-null when `if(earlyStopValidation &&
_validateState.isLossIncreased()` never be true.
---
