Github user takuti commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/149#discussion_r191145436
  
    --- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java ---
    @@ -563,6 +580,10 @@ protected void runTrainingIteration(int iterations) 
throws HiveException {
                     inputBuf.flip();
     
                     for (int iter = 2; iter <= iterations; iter++) {
    +                    if (earlyStopValidation) {
    --- End diff --
    
    `_validateState = NULL` allows us to confirm if at least one validation 
sample exists && early stopping option is enabled. Thanks to this 
implementation, we can avoid unnecessary call of `cacheCurrentModel` which 
consumes extra memory to hold the best model parameters.


---

Reply via email to