Adalennis opened a new pull request, #9118: URL: https://github.com/apache/hop/pull/9118
Addresses #8970 Sixth batch: a Result section on the pages of the workflow control actions: Start, Dummy, Success, Abort, Write to log, Wait for, Join and Set variables. Every row comes from a hop-run test against the current code (32 workflows). Besides true and false, the tests show which hops are followed (each tested action had a success, a failure and an unconditional hop), whether an action keeps the error count of the previous action (a Delete folders before it ends true with 2 errors), and what reaches the next action: - Start and Dummy don't evaluate a result: only their unconditional hops are followed. - Abort follows no hop at all, not even an unconditional one, and hop-run ends with exit code 1. - Write to log and Wait for keep the error count of the previous action; Success, Dummy and Set variables pass on 0 errors. - Join is false with one error per branch that ended false on a success hop, or that can no longer run because of an earlier failure. It passes on the result files and rows of one branch only: when several branches add files or rows, only those of one branch reach the next action. - Set variables fails when the properties file can't be read, and when Valid in the parent is used in a workflow without a parent workflow. Also fixed: - Set variables: the table header had `width="90%". cols` (a full stop instead of a comma), so its options did not render as a table; Valid in the Java Virtual Machine label. - Wait for: the dialog has Maximum timeout with a Seconds / Minutes / Hours list, not "Wait for" and "Unit time". - Success and Set variables: "Action name" instead of "Workflow action name". One behaviour that may be worth an issue: Join drops the result files and rows of all branches but one. I documented it as it is. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
