bamaer commented on PR #9118: URL: https://github.com/apache/hop/pull/9118#issuecomment-6461359951
@Adalennis Docs-only, so nothing here can break anything. I checked the Result rows against the action code and ran a few cases with hop-run, and they match. All 8 pages render with asciidoctor, including the fixed Set variables options table. **Worth fixing** - Write to log / Wait for: the True row says the previous action's error count is kept, but not what that does. With Write to log as the last action on a failure path, the action is true but the workflow still ends as failed. Pipeline (fails, 1 error) → red hop → Write to log gives `result=[true]` and hop-run exit code 1. With a Success or a Dummy after it, the exit code is 0. Suggest adding a line to the True row in `writetolog.adoc` and `waitfor.adoc`, for example: "As the last action after a failed action, the workflow still ends as failed: add a Success action after it to end successfully." LGTM otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
