AnKiT-GaRG2 opened a new pull request, #9182:
URL: https://github.com/apache/hop/pull/9182

   The Sheets tab of Microsoft Excel Input accepts variables in the sheet name, 
but with Regex = No the name was taken from the metadata as is, so `${VAR}` 
never matched a sheet. The Regex = Yes path already called `resolve()`.
   
   Resolve each configured sheet name when the sheets are set up in `init()`. 
Added a test that reads a sheet named through a variable; it fails without the 
fix (0 rows) and passes with it.
   
   addresses #9116
   
   - [x] Excel input tests pass (`ExcelInput*Test`, 24 tests); formatting 
applied
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to